Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] Remove usage of deprecated functions in benchmarks #1193

Merged
merged 1 commit into from Jun 9, 2020

Conversation

yuanming-hu
Copy link
Member

Copy link
Collaborator

@archibate archibate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would you mind also deprecate @ti.layout from tests?
Also BTW that I failed to run benchmark on my machine due to out-of-memory error when running the huge memcpy benchmark, can we reduce it? Or I should TI_DEVICE_MEMORY_FRACTION=1?

@yuanming-hu
Copy link
Member Author

Thanks! Would you mind also deprecate @ti.layout from tests?

Sure, I'll do that once I have time. If you'd like to help, please go ahead.

Also BTW that I failed to run benchmark on my machine due to out-of-memory error when running the huge memcpy benchmark, can we reduce it? Or I should TI_DEVICE_MEMORY_FRACTION=1?

The memcpy tests allocate huge trunks of memory...I'll try to reduce it in the future.

@yuanming-hu yuanming-hu merged commit 49a48df into taichi-dev:master Jun 9, 2020
@yuanming-hu yuanming-hu mentioned this pull request Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants