-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] Fix matrix operations to use numpy only in Python scope #1208
Conversation
Thanks for the fix @k-ye ! AFIK, there are 3 efforts now trying to resolve this issue: #1184 #1188 , since we are trying to fix it in the next release asap, we might want to come up with a plan on how to consolidate them and what is the short/long term plan for this. Besides that, |
Codecov Report
@@ Coverage Diff @@
## master #1208 +/- ##
==========================================
+ Coverage 66.85% 67.08% +0.22%
==========================================
Files 35 35
Lines 4827 4827
Branches 885 885
==========================================
+ Hits 3227 3238 +11
+ Misses 1424 1414 -10
+ Partials 176 175 -1
Continue to review full report at Codecov.
|
Thank for fixing this! We may merge this for a temp solution in v0.6.9. But IMHO for long term consideration, v0.6.10, we should use #1188 as ultimate solution, which doesn't rely on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
Thanks for the quick review, and sorry about the redundant works! I agree that we should do this systematically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This PR now supersedes #1184
Thank for the quick solution, please don't forget to take a look at #1188 when you have time :) |
is_pyconstant
is not enough because there are cases where constantti.Vector
s are used in the taichi scope. For example:taichi/examples/cornell_box.py
Line 37 in 6518a21
This PR adds
in_taichi_scope()
andin_python_scope()
helpers to make cornell box run again. As a slightly off the topic change, I also adopted the newgui.is_running
to this example.Related issue = #1051, #1190