Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llvm] [cuda] Improve LLVM 8 compatibility #1210

Merged
merged 2 commits into from
Jun 10, 2020

Conversation

yuanming-hu
Copy link
Member

Related issue = #1204

@archibate could you test if this solves your problem? Thanks!

@archibate
Copy link
Collaborator

Did solve my problem! So what's the ultimate solution?

@yuanming-hu
Copy link
Member Author

Did solve my problem! So what's the ultimate solution?

Let's see if the problem persists after we upgrade to LLVM 10. If it's gone with LLVM 10, we don't need to do anything :-)

Sorry, but I'd revert your commit since we don't want the users to get error messages.

@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #1210 into master will decrease coverage by 1.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1210      +/-   ##
==========================================
- Coverage   67.10%   65.98%   -1.12%     
==========================================
  Files          35       35              
  Lines        4831     4669     -162     
  Branches      885      885              
==========================================
- Hits         3242     3081     -161     
+ Misses       1414     1413       -1     
  Partials      175      175              
Impacted Files Coverage Δ
python/taichi/misc/task.py 75.00% <0.00%> (-5.00%) ⬇️
python/taichi/lang/ops.py 92.09% <0.00%> (-1.57%) ⬇️
python/taichi/lang/matrix.py 83.42% <0.00%> (-1.38%) ⬇️
python/taichi/main.py 42.46% <0.00%> (-1.07%) ⬇️
python/taichi/lang/util.py 50.93% <0.00%> (-0.90%) ⬇️
python/taichi/misc/gui.py 23.72% <0.00%> (-0.71%) ⬇️
python/taichi/lang/ast_checker.py 87.87% <0.00%> (-0.70%) ⬇️
python/taichi/lang/linalg.py 89.33% <0.00%> (-0.67%) ⬇️
python/taichi/lang/expr.py 87.42% <0.00%> (-0.65%) ⬇️
python/taichi/lang/meta.py 61.90% <0.00%> (-0.60%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bec9bdb...67ccfc2. Read the comment docs.

@yuanming-hu yuanming-hu merged commit 2fba8a6 into taichi-dev:master Jun 10, 2020
@yuanming-hu yuanming-hu mentioned this pull request Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants