Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workflow] Improve PR title checker for the release tag #1244

Merged
merged 3 commits into from Jun 17, 2020

Conversation

archibate
Copy link
Collaborator

@archibate archibate commented Jun 14, 2020

Related issue = #1241

[Click here for the format server]


[release] v0.6.10, here v is lowercase, so error comes.
We only want to make other PRs to be uppercased like [lang] Hello world but not for [release].
I tweaked PR title checker to make it support a separate checking logic for [release] PRs.
It also support semver bump checking in case we make wrong :) @FantasyVR
e.g.: v0.6.10 -> v0.6.12 ERROR! v0.6. ERROR!

@FantasyVR
Copy link
Collaborator

Great, it can be used when releasing next version.

@archibate archibate added the LGTM label Jun 16, 2020
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Feel free to merge after the wording fixes are applied. Let's see how this work :-)

misc/check_pr_title.py Outdated Show resolved Hide resolved
misc/check_pr_title.py Outdated Show resolved Hide resolved
misc/check_pr_title.py Outdated Show resolved Hide resolved
Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com>
@archibate archibate merged commit 6963c30 into taichi-dev:master Jun 17, 2020
@FantasyVR FantasyVR mentioned this pull request Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants