Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [lang] Fix outer_product output matrix shape #1461

Conversation

archibate
Copy link
Collaborator

Related issue = fixes #1460

[Click here for the format server]


Thank @gmh14 for reporting!
I made the test to use different size in rhs and lhs to prevent regression.

@codecov
Copy link

codecov bot commented Jul 11, 2020

Codecov Report

Merging #1461 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1461      +/-   ##
==========================================
- Coverage   66.69%   66.64%   -0.05%     
==========================================
  Files          38       38              
  Lines        5305     5310       +5     
  Branches      948      948              
==========================================
+ Hits         3538     3539       +1     
- Misses       1607     1611       +4     
  Partials      160      160              
Impacted Files Coverage Δ
python/taichi/lang/matrix.py 91.19% <ø> (ø)
python/taichi/lang/ops.py 92.41% <0.00%> (-1.34%) ⬇️
python/taichi/core/util.py 21.72% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65bf964...73a7246. Read the comment docs.

Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this!

@yuanming-hu yuanming-hu changed the title [Bug] [lang] Fix outer_product not giving correct matrix shape [Bug] [lang] Fix outer_product output matrix shape Jul 11, 2020
@yuanming-hu yuanming-hu merged commit 846fc15 into taichi-dev:master Jul 11, 2020
@FantasyVR FantasyVR mentioned this pull request Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] outer_product() get automatically truncated from v0.6.16
2 participants