Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] Add is_path_all_dense to SNode #1538

Merged
merged 1 commit into from
Jul 19, 2020
Merged

[misc] Add is_path_all_dense to SNode #1538

merged 1 commit into from
Jul 19, 2020

Conversation

k-ye
Copy link
Member

@k-ye k-ye commented Jul 19, 2020

Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

taichi/ir/snode.cpp Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 19, 2020

Codecov Report

Merging #1538 into master will increase coverage by 0.60%.
The diff coverage is 87.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1538      +/-   ##
==========================================
+ Coverage   86.10%   86.71%   +0.60%     
==========================================
  Files          19       19              
  Lines        3548     3680     +132     
  Branches      631      652      +21     
==========================================
+ Hits         3055     3191     +136     
+ Misses        365      355      -10     
- Partials      128      134       +6     
Impacted Files Coverage Δ
python/taichi/lang/kernel.py 82.77% <ø> (+1.20%) ⬆️
python/taichi/lang/impl.py 89.41% <63.15%> (-1.14%) ⬇️
python/taichi/lang/matrix.py 91.55% <71.79%> (+0.12%) ⬆️
python/taichi/lang/meta.py 64.70% <75.00%> (+2.20%) ⬆️
python/taichi/lang/__init__.py 80.05% <78.94%> (+0.58%) ⬆️
python/taichi/lang/transformer.py 93.70% <95.00%> (+0.08%) ⬆️
python/taichi/lang/ops.py 93.33% <95.55%> (+0.20%) ⬆️
python/taichi/lang/snode.py 93.69% <100.00%> (+6.65%) ⬆️
python/taichi/lang/util.py 62.26% <100.00%> (-2.45%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3415669...3785732. Read the comment docs.

@k-ye k-ye merged commit 729d10b into taichi-dev:master Jul 19, 2020
@k-ye k-ye deleted the snode branch July 19, 2020 14:50
@FantasyVR FantasyVR mentioned this pull request Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants