[linux] Fix LLVM symbol leakage in release mode by using RTLD_GLOBAL #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archibate
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1544 +/- ##
==========================================
- Coverage 67.53% 66.31% -1.23%
==========================================
Files 38 40 +2
Lines 5624 5438 -186
Branches 980 981 +1
==========================================
- Hits 3798 3606 -192
- Misses 1657 1662 +5
- Partials 169 170 +1
Continue to review full report at Codecov.
|
yuanming-hu
approved these changes
Jul 20, 2020
python/taichi/lang/matrix.py
Outdated
| _taichi_skip_traceback = 1 | ||
| assert 0 <= args[0] < self.n, \ | ||
| f"The 0-th matrix index {args[0]} out-of-range, should be < {self.n}" |
There was a problem hiding this comment.
Specify the lower bound as well?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR = #1508
[Click here for the format server]
Why release mode use different code than
import_ti_corein dev mode... and I found the glfw issue again in release mode.