Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opengl] Fix reversed nested for loops error on OpenGL #1554

Merged
merged 2 commits into from
Jul 22, 2020

Conversation

archibate
Copy link
Collaborator

Related issue = #

[Click here for the format server]


Before this PR:

for (int F_ = E - F; 1_ >= D; F_ -= 1) {

Well, 1_...
After this PR:

for (int F_ = E - 1; F_ >= D; F_ -= 1) {

@archibate archibate requested a review from k-ye July 21, 2020 16:32
@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #1554 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1554   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files          19       19           
  Lines        3680     3681    +1     
  Branches      652      652           
=======================================
+ Hits         3191     3192    +1     
  Misses        355      355           
  Partials      134      134           
Impacted Files Coverage Δ
python/taichi/lang/matrix.py 91.56% <0.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 135055a...ab593b4. Read the comment docs.

Copy link
Collaborator

@xumingkuan xumingkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@archibate archibate added the LGTM label Jul 22, 2020
@archibate archibate merged commit ea9618e into taichi-dev:master Jul 22, 2020
@FantasyVR FantasyVR mentioned this pull request Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants