Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Move Context to taichi/program #1788

Merged
merged 3 commits into from Aug 28, 2020
Merged

Conversation

k-ye
Copy link
Member

@k-ye k-ye commented Aug 27, 2020

@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #1788 into master will decrease coverage by 0.10%.
The diff coverage is 36.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1788      +/-   ##
==========================================
- Coverage   42.61%   42.50%   -0.11%     
==========================================
  Files          44       44              
  Lines        6183     6194      +11     
  Branches     1071     1073       +2     
==========================================
- Hits         2635     2633       -2     
- Misses       3394     3406      +12     
- Partials      154      155       +1     
Impacted Files Coverage Δ
python/taichi/lang/expr.py 60.63% <16.66%> (-1.32%) ⬇️
python/taichi/lang/matrix.py 64.34% <16.66%> (-0.39%) ⬇️
python/taichi/lang/snode.py 64.22% <57.14%> (-1.61%) ⬇️
python/taichi/lang/ops.py 43.56% <66.66%> (-0.33%) ⬇️
python/taichi/testing.py 75.75% <0.00%> (-2.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0077ccb...2621391. Read the comment docs.

taichi/program/context.h Show resolved Hide resolved
taichi/system/memory_pool.h Show resolved Hide resolved
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! LGTM. Thanks.

@k-ye k-ye merged commit da41c85 into taichi-dev:master Aug 28, 2020
@k-ye k-ye deleted the context branch August 28, 2020 10:35
@yuanming-hu yuanming-hu mentioned this pull request Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants