Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] Fix check previous run by using GITHUB_TOKEN to authenticate APIs #1849

Merged
merged 4 commits into from Sep 7, 2020

Conversation

k-ye
Copy link
Member

@k-ye k-ye commented Sep 6, 2020

Intentionally mess up the cpp code to make taichi-gardener work.

Related issue = #1844 (comment), #1837

[Click here for the format server]


@k-ye
Copy link
Member Author

k-ye commented Sep 6, 2020

@archibate You can monitor the run status of the last commit by @taichi-gardener 's in https://github.com/taichi-dev/taichi/runs/1077882106. Note that rate limit is 1000 now.

@k-ye k-ye requested a review from archibate September 6, 2020 12:55
@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #1849 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1849      +/-   ##
==========================================
- Coverage   44.16%   44.13%   -0.03%     
==========================================
  Files          44       44              
  Lines        6075     6072       -3     
  Branches     1088     1088              
==========================================
- Hits         2683     2680       -3     
  Misses       3223     3223              
  Partials      169      169              
Impacted Files Coverage Δ
python/taichi/lang/transformer.py 81.88% <0.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8864f37...0dc35f2. Read the comment docs.

@k-ye
Copy link
Member Author

k-ye commented Sep 7, 2020

I'm merging this directly because it imposes no risk to Taichi itself. Also, we need this to prevent the workflow runs from being too flaky. It is possible that we have to iterate on this a few rounds before it finally gets stable.

@k-ye k-ye merged commit 0520149 into taichi-dev:master Sep 7, 2020
@k-ye k-ye deleted the auth-action branch September 7, 2020 11:33
@yuanming-hu yuanming-hu mentioned this pull request Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants