[Lang] Support ti.zero(x) and ti.one(x) for making zero/one value for the same type with x #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the same type with x
archibate
requested review from
xumingkuan,
k-ye and
yuanming-hu
and removed request for
xumingkuan,
k-ye and
yuanming-hu
Codecov Report
@@ Coverage Diff @@
## master #1857 +/- ##
==========================================
+ Coverage 44.06% 44.21% +0.15%
==========================================
Files 44 44
Lines 6089 6111 +22
Branches 1089 1092 +3
==========================================
+ Hits 2683 2702 +19
- Misses 3237 3240 +3
Partials 169 169
Continue to review full report at Codecov.
|
k-ye
approved these changes
Sep 9, 2020
tests/python/test_lang.py
Outdated
| @@ -131,3 +132,29 @@ def test(): | |||
| print(i) | |||
|
|
|||
| test() | |||
|
|
|||
|
|
|||
| @ti.test(require=ti.extension.data64) | |||
There was a problem hiding this comment.
IIUC, this applies to all the test cases, so platforms like Metal cannot be covered, even for 32-bit types? If so, could you split this into two cases, one for 64-bit and the other for non-64?
| if ti.core.is_integral(dt): | ||
| x = int(x) | ||
| assert func(x) == 0 # intentionally not using ti.approx here | ||
|
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = http://www.jlhub.com/julia/manual/en/function/zero
[Click here for the format server]
Yeah it's still using
x * 0since we seems can't get the data type of an expr from python-scope.. maybe iapr, let's set up the API here imutating the Julia zero/one.