New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[async] Classify tasks to make fusion 10.6x faster #1887
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1887 +/- ##
==========================================
+ Coverage 43.19% 43.80% +0.61%
==========================================
Files 44 45 +1
Lines 6330 6168 -162
Branches 1092 1097 +5
==========================================
- Hits 2734 2702 -32
+ Misses 3426 3297 -129
+ Partials 170 169 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
Related issue = #742
Benchmark: async_mgpcg.py,
taichi::lang::StateFlowGraph::fuse
:Before:
2.815 s
At commit 691f706:
520.011 ms
At commit 3c78343:
332.199 ms
At commit 42da16c:
283.921 ms
At commit 366af3d (buggy):
197.838 ms
At commit 826d053:
241.768 ms
After (at commit 6e6892f):
152.634 ms
On kun: ~1.03s -> ~97ms (10.6x faster)
The following statistics may change even at the same commit...
Without fusion:
With fusion (before this PR):
With fusion (at commit 691f706):
With fusion (at commit 42da16c):
With fusion (at commit 366af3d):
With fusion (at commit 826d053):
With fusion (at commit 6e6892f):
[Click here for the format server]