Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] Expose kernel statistics to python #1891

Merged
merged 1 commit into from Sep 25, 2020
Merged

Conversation

k-ye
Copy link
Member

@k-ye k-ye commented Sep 25, 2020

This allows us to ensure fusion does work and to detect possible regressions...

As a slightly off-the-topic change, i changed the tests to use ti.pointer.dense.place() as suggested in #1888 (comment). dense(1) is still pointless, but it eases the activated index computation.

Related issue = #N/A

[Click here for the format server]


@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #1891 into master will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1891   +/-   ##
=======================================
  Coverage   43.80%   43.81%           
=======================================
  Files          45       45           
  Lines        6168     6174    +6     
  Branches     1097     1097           
=======================================
+ Hits         2702     2705    +3     
- Misses       3297     3300    +3     
  Partials      169      169           
Impacted Files Coverage Δ
python/taichi/lang/ops.py 52.44% <33.33%> (-0.21%) ⬇️
python/taichi/misc/util.py 18.27% <66.66%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25b9a10...0eca509. Read the comment docs.

Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!! LGTM. Thank you!

@yuanming-hu yuanming-hu merged commit 6ac1a54 into taichi-dev:master Sep 25, 2020
@xumingkuan
Copy link
Collaborator

Cool! (off-topic: Is there a fast way to sort the #include statements in lexicographical order with IDEs like CLion?)

@yuanming-hu yuanming-hu mentioned this pull request Sep 26, 2020
@k-ye k-ye deleted the stats branch October 18, 2020 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants