Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] Make check previous CI run only check for Build-and-Test jobs #1899

Merged
merged 6 commits into from Sep 26, 2020

Conversation

k-ye
Copy link
Member

@k-ye k-ye commented Sep 26, 2020

When the previous CI run's code format check fails, two thing happens:

  1. @taichi-gardener will do a [skip ci] enforce code format to automatically correct the things
  2. The second commit would still fail because it runs "Check the previous CI workflow" job, which finds that the previous workflow... has failed --> this time it fails again :-/

"Persubmit Checks / Code Format (pull_request)" is triggered unconditionally now, because it is a required check. (Previously it is disabled for @taichi-gardener 's commits)

Related issue = #1809

[Click here for the format server]


@k-ye k-ye changed the title [ci] Make check previous CI run only check for Build-and-Test jobs [misc] Make check previous CI run only check for Build-and-Test jobs Sep 26, 2020
Copy link
Collaborator

@xumingkuan xumingkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@codecov
Copy link

codecov bot commented Sep 26, 2020

Codecov Report

Merging #1899 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1899   +/-   ##
=======================================
  Coverage   43.81%   43.81%           
=======================================
  Files          45       45           
  Lines        6174     6174           
  Branches     1097     1097           
=======================================
  Hits         2705     2705           
  Misses       3300     3300           
  Partials      169      169           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27f59d0...22dc629. Read the comment docs.

@k-ye
Copy link
Member Author

k-ye commented Sep 26, 2020

Seems like we have one more thing to be addressed: "Build and Test (CPU) (ubuntu-latest, 3.6, OFF)" is a required check for merging, but it's skipped for @taichi-gardener 's commits. I probably need to add another job to gather the test result, and make that a required check instead...

@k-ye k-ye merged commit 1446e8a into taichi-dev:master Sep 26, 2020
@k-ye k-ye deleted the sep-format branch September 26, 2020 11:47
@yuanming-hu yuanming-hu mentioned this pull request Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants