Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ir] Generate yaml documentation for statement classes #2192

Merged
merged 5 commits into from Mar 3, 2021
Merged

[ir] Generate yaml documentation for statement classes #2192

merged 5 commits into from Mar 3, 2021

Conversation

xumingkuan
Copy link
Collaborator

@xumingkuan xumingkuan commented Feb 27, 2021 •
edited

yuanming-hu
yuanming-hu approved these changes Feb 27, 2021
View reviewed changes
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks.

taichi/ir/statements.h Outdated Show resolved Hide resolved
taichi/ir/statements.h Outdated Show resolved Hide resolved
xumingkuan and others added 2 commits February 27, 2021 18:13
@xumingkuan
Also generates markdown file
4ab1e52
@xumingkuan @yuanming-hu
Apply suggestions from code review
6978449 
Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com>
BillXu2000
BillXu2000 approved these changes Feb 28, 2021
View reviewed changes
Copy link
Collaborator

@BillXu2000 BillXu2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

k-ye
k-ye reviewed Feb 28, 2021
View reviewed changes
misc/generate_ir_design_doc.py Outdated Show resolved Hide resolved
taichi/ir/statements.h Outdated Show resolved Hide resolved
xumingkuan and others added 2 commits March 1, 2021 17:01
@xumingkuan @k-ye
Update taichi/ir/statements.h
8a20a64 
Co-authored-by: Ye Kuang <k-ye@users.noreply.github.com>
@xumingkuan
Apply review
df6e6ed
@yuanming-hu yuanming-hu merged commit dee35f4 into taichi-dev:master Mar 3, 2021
@xumingkuan xumingkuan deleted the doc1 branch March 13, 2021 12:15
@k-ye k-ye mentioned this pull request Mar 14, 2021
Merged
@xumingkuan xumingkuan mentioned this pull request Apr 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-ye k-ye k-ye left review comments

@yuanming-hu yuanming-hu yuanming-hu approved these changes

@BillXu2000 BillXu2000 BillXu2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xumingkuan @yuanming-hu @k-ye @BillXu2000