Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lang] Support std::optional and enum classes in the serializer #2350

Merged
merged 2 commits into from May 18, 2021
Merged

[lang] Support std::optional and enum classes in the serializer #2350

merged 2 commits into from May 18, 2021

Conversation

k-ye
Copy link
Member

@k-ye k-ye commented May 17, 2021

Related issue = #N/A

Could be useful for AOT

[Click here for the format server]

@k-ye k-ye requested a review from xumingkuan May 17, 2021 09:55
xumingkuan
xumingkuan approved these changes May 17, 2021
View reviewed changes
Copy link
Collaborator

@xumingkuan xumingkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@k-ye k-ye merged commit 03ddb7a into taichi-dev:master May 18, 2021
@k-ye k-ye deleted the serial branch May 18, 2021 01:00
@xumingkuan xumingkuan mentioned this pull request May 20, 2021
Merged
@k-ye k-ye mentioned this pull request May 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xumingkuan xumingkuan xumingkuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@k-ye @xumingkuan