[ir] Add nodiscard to get_loop_guard/get_if_guard #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-ye
approved these changes
May 29, 2021
xumingkuan
commented
May 29, 2021
taichi/ir/ir_builder.h
Outdated
| @@ -92,8 +92,7 @@ class IRBuilder { | |||
| template <typename XStmt> | |||
| [[nodiscard]] LoopGuard get_loop_guard(XStmt *loop) { | |||
| return LoopGuard(*this, loop); | |||
| } | |||
| [[nodiscard]] IfGuard get_if_guard(IfStmt *if_stmt, bool true_branch) { | |||
| }[[nodiscard]] IfGuard get_if_guard(IfStmt *if_stmt, bool true_branch) { | |||
This reverts commit 21a932b
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #2193
This PR warns CHI users when they write
builder.get_loop_guard(loop);which has no effect. The correct usage isauto _ = builder.get_loop_guard(loop);.[Click here for the format server]