Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Change build method of ci tests #2661

Merged
merged 3 commits into from Aug 11, 2021
Merged

[ci] Change build method of ci tests #2661

merged 3 commits into from Aug 11, 2021

Conversation

Leonz5288
Copy link
Contributor

Related issue = #

ailzhang
ailzhang reviewed Aug 11, 2021
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just realized that the cpp tests were accidentally removed, so we need to bring them back before merging ;)

.github/workflows/presubmit.yml Outdated Show resolved Hide resolved
.github/workflows/presubmit.yml Show resolved Hide resolved
.github/workflows/presubmit.yml Outdated Show resolved Hide resolved
.github/workflows/presubmit.yml Outdated Show resolved Hide resolved
.github/workflows/presubmit.yml Show resolved Hide resolved
@strongoier
Copy link
Contributor

BTW torch has just been added to ci_setup.py (See #2656). You might also need to add it to requirements_dev.txt

ailzhang
ailzhang approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please feel free to merge once CI passes!

@Leonz5288
Copy link
Contributor Author

BTW torch has just been added to ci_setup.py (See #2656). You might also need to add it to requirements_dev.txt

Thanks for the info!

@ailzhang ailzhang merged commit b5259e2 into taichi-dev:master Aug 11, 2021
@Leonz5288 Leonz5288 deleted the newbuild branch August 11, 2021 10:19
@Leonz5288 Leonz5288 mentioned this pull request Aug 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ailzhang ailzhang ailzhang approved these changes

@k-ye k-ye Awaiting requested review from k-ye

@ljcc0930 ljcc0930 Awaiting requested review from ljcc0930

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Leonz5288 @strongoier @ailzhang