Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Add more complicated tests for building and destroying SNodeTrees #3415

Merged
merged 35 commits into from
Dec 23, 2021
Merged

[test] Add more complicated tests for building and destroying SNodeTrees #3415

merged 35 commits into from
Dec 23, 2021

Conversation

ysh329
Copy link
Contributor

@ysh329 ysh329 commented Nov 7, 2021 •
edited

Status: waiting for review

Related issue = #2724

  1. Add more compliated test for destroying and building of field builder:
    1. test field with shape;
    2. test fields builder dense;
    3. test_fields builder pointer;
    4. test fields builder destroy.
  2. Re sort out and rename existing tests.

Please give some advice etc.

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Nov 7, 2021 •
edited

✔️ Deploy Preview for jovial-fermat-aa59dc ready!

🔨 Explore the source changes: 7d87378

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61c31251d4e2f60008129a31

😎 Browse the preview: https://deploy-preview-3415--jovial-fermat-aa59dc.netlify.app

@ysh329 ysh329 changed the title [WIP][TEST] Add more compliated test for destroying and building of field builder. [TEST] Add more compliated test for destroying and building of field builder. Nov 8, 2021
@ysh329
Copy link
Contributor Author

ysh329 commented Nov 8, 2021 •
edited

I found a python format error as blew from link(https://github.com/taichi-dev/taichi/runs/4135911412?check_suite_focus=true):
image

Do i need install pre-commit tools or pylint? have any docs?

@strongoier
Copy link
Contributor

/format

strongoier
strongoier reviewed Nov 9, 2021
View reviewed changes
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! A little suggestion: try to run locally first :-)

tests/python/test_fields_builder.py Outdated Show resolved Hide resolved
tests/python/test_fields_builder.py Outdated Show resolved Hide resolved
tests/python/test_fields_builder.py Show resolved Hide resolved
tests/python/test_fields_builder.py Outdated Show resolved Hide resolved
qiao-bo
qiao-bo reviewed Nov 10, 2021
View reviewed changes
Copy link
Collaborator

@qiao-bo qiao-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

tests/python/test_fields_builder.py Outdated Show resolved Hide resolved
tests/python/test_fields_builder.py Outdated Show resolved Hide resolved
tests/python/test_fields_builder.py Outdated Show resolved Hide resolved
tests/python/test_fields_builder.py Outdated Show resolved Hide resolved
tests/python/test_fields_builder.py Outdated Show resolved Hide resolved
tests/python/test_fields_builder.py Outdated Show resolved Hide resolved
@ysh329
Copy link
Contributor Author

ysh329 commented Nov 19, 2021

/format

2 similar comments
@ysh329
Copy link
Contributor Author

ysh329 commented Nov 19, 2021

/format

@qiao-bo
Copy link
Collaborator

qiao-bo commented Nov 19, 2021

/format

@qiao-bo
Copy link
Collaborator

qiao-bo commented Nov 19, 2021

Hi, can you please fix the errors? thanks

@strongoier
Copy link
Contributor

/format

strongoier
strongoier suggested changes Dec 14, 2021
View reviewed changes
tests/python/test_fields_builder.py Outdated Show resolved Hide resolved
tests/python/test_fields_builder.py Outdated Show resolved Hide resolved
tests/python/test_fields_builder.py Outdated Show resolved Hide resolved
@strongoier
Copy link
Contributor

/format

@yuanming-hu yuanming-hu changed the title [TEST] Add more compliated test for destroying and building of field builder. [Test] Add more compliated test for destroying and building of field builder. Dec 16, 2021
@ysh329
Copy link
Contributor Author

ysh329 commented Dec 19, 2021

XDM @strongoier @qiao-bo 😭 , it seems CI is stucked.

strongoier
strongoier suggested changes Dec 20, 2021
View reviewed changes
tests/python/test_fields_builder.py Show resolved Hide resolved
tests/python/test_fields_builder.py Outdated Show resolved Hide resolved
tests/python/test_fields_builder.py Outdated Show resolved Hide resolved
tests/python/test_fields_builder.py Outdated Show resolved Hide resolved
tests/python/test_fields_builder.py Outdated Show resolved Hide resolved
strongoier
strongoier approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your efforts and patience for finally finishing this! :-)

@strongoier
Copy link
Contributor

/format

@strongoier strongoier changed the title [Test] Add more compliated test for destroying and building of field builder. [test] Add more complicated tests for building and destroying SNodeTrees Dec 22, 2021
qiao-bo
qiao-bo approved these changes Dec 22, 2021
View reviewed changes
Copy link
Collaborator

@qiao-bo qiao-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! and thanks for the work!

@strongoier strongoier merged commit 198bd39 into taichi-dev:master Dec 23, 2021
@ysh329 ysh329 deleted the test-py-fields-enhance-builder-for-building-and-destroying branch December 23, 2021 06:09
@ailzhang ailzhang mentioned this pull request Dec 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strongoier strongoier strongoier approved these changes

@qiao-bo qiao-bo qiao-bo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ysh329 @CLAassistant @strongoier @qiao-bo @taichi-gardener