Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] [bug] Eliminate failing tests on the new AST builder #3441

Merged
merged 13 commits into from Nov 11, 2021

Conversation

lin-hitonami
Copy link
Collaborator

Related issue = #3038

@netlify
Copy link

netlify bot commented Nov 10, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc ready!

🔨 Explore the source changes: a14b79b

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/618ca5dc3084e10008c9d7d1

😎 Browse the preview: https://deploy-preview-3441--jovial-fermat-aa59dc.netlify.app

@lin-hitonami lin-hitonami marked this pull request as ready for review November 10, 2021 09:13
misc/code_format.py Outdated Show resolved Hide resolved
tests/python/test_type_check.py Show resolved Hide resolved
Co-authored-by: Ye Kuang <k-ye@users.noreply.github.com>
@lin-hitonami
Copy link
Collaborator Author

/format

Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lin-hitonami lin-hitonami merged commit b1ed57d into taichi-dev:master Nov 11, 2021
@lin-hitonami lin-hitonami deleted the ast_refactor branch November 11, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants