Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IR] Add type_check for Atomic/SNodeOpExpression #3444

Merged
merged 4 commits into from Nov 11, 2021

Conversation

strongoier
Copy link
Contributor

Related issue = #3301

@strongoier strongoier requested a review from k-ye November 10, 2021 07:29
@netlify
Copy link

netlify bot commented Nov 10, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: 5afcee4

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/618b82ec2b3e190007ba2173

@strongoier strongoier requested review from ailzhang, k-ye and lin-hitonami and removed request for k-ye November 10, 2021 07:29
@strongoier
Copy link
Contributor Author

/format

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@strongoier strongoier merged commit 6617388 into taichi-dev:master Nov 11, 2021
@strongoier strongoier deleted the type-check-atomic branch November 11, 2021 05:39
sjwsl pushed a commit to sjwsl/taichi that referenced this pull request Nov 11, 2021
* Type check for atomic op

* Type check for snode op

* Auto Format

Co-authored-by: Taichi Gardener <taichigardener@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants