Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[misc] Enable clang-tidy check in CI #3475

Merged
merged 4 commits into from Nov 12, 2021
Merged

[misc] Enable clang-tidy check in CI #3475

merged 4 commits into from Nov 12, 2021

Conversation

sjwsl
Copy link
Collaborator

@sjwsl sjwsl commented Nov 12, 2021

Related issue = #

@sjwsl sjwsl requested a review from ailzhang November 12, 2021 07:33
@netlify
Copy link

netlify bot commented Nov 12, 2021 •
edited

✔️ Deploy Preview for jovial-fermat-aa59dc ready!

🔨 Explore the source changes: 8266743

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/618e68025ba70f00076f72b1

😎 Browse the preview: https://deploy-preview-3475--jovial-fermat-aa59dc.netlify.app

ailzhang
ailzhang approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Btw I took a look at our log and it's a bit too verbose :P . Can we have a followup that:

  • If clang-tidy passes, let's just print one sentence and celebrate
  • If it fails, clearly list the offending file names and a command to reproduce.

.github/workflows/presubmit.yml Show resolved Hide resolved
@sjwsl
Copy link
Collaborator Author

sjwsl commented Nov 12, 2021

/format

@sjwsl sjwsl requested a review from ailzhang November 12, 2021 13:21
ailzhang
ailzhang approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks!

@ailzhang ailzhang merged commit d51b85d into taichi-dev:master Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ailzhang ailzhang ailzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sjwsl @ailzhang @taichi-gardener