Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lang] Fix pylint rule W0108 #3482

Merged
merged 9 commits into from Nov 13, 2021
Merged

[Lang] Fix pylint rule W0108 #3482

merged 9 commits into from Nov 13, 2021

Conversation

nasnoisaac
Copy link
Contributor

Related issue #3151

@netlify
Copy link

netlify bot commented Nov 12, 2021 •
edited

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: a9cacd5

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/618fd414c1d6b4000889fdb7

@CLAassistant
Copy link

CLAassistant commented Nov 12, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@k-ye k-ye self-requested a review November 12, 2021 12:46
k-ye
k-ye approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Could you sign the CLA and resolve the conflicts, please :-)

@nasnoisaac
Copy link
Contributor Author

Updated @k-ye

k-ye
k-ye approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will merge after CI

@nasnoisaac
Copy link
Contributor Author

/format

@sjwsl sjwsl merged commit 8b39d02 into taichi-dev:master Nov 13, 2021
@nasnoisaac nasnoisaac deleted the format-W0108 branch November 14, 2021 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjwsl sjwsl sjwsl left review comments

@k-ye k-ye k-ye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nasnoisaac @CLAassistant @k-ye @sjwsl @ailzhang