New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lang] Fix pylint rule W0235 #3486
Conversation
✔️ Deploy Preview for jovial-fermat-aa59dc canceled. 🔨 Explore the source changes: a6233a6 🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/6190693562c0fb00088258e7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, welcome to the community!
@@ -134,8 +131,5 @@ def particles(self, | |||
vbo_info = get_field_info(vbo) | |||
super().particles(vbo_info, has_per_vertex_color, color, radius) | |||
|
|||
def point_light(self, pos, color): | |||
def point_light(self, pos, color): # pylint: disable=W0235 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why handling this differently :-) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/taichi-dev/taichi/runs/4191773093
@k-ye CI fails, but I'm not familiar with pybind11.
Thanks @sjwsl |
Related issue = #3151