Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lang] Fix pylint rule W0612 (#3151) #3488

Merged
merged 2 commits into from Nov 14, 2021
Merged

[Lang] Fix pylint rule W0612 (#3151) #3488

merged 2 commits into from Nov 14, 2021

Conversation

MerleLiuKun
Copy link
Contributor

Related issue = #3151

@CLAassistant
Copy link

CLAassistant commented Nov 13, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Nov 13, 2021 •
edited

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: bfba8d9

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/6190d48f0c718a0007be6cdd

@k-ye
Copy link
Member

k-ye commented Nov 13, 2021

/format

@MerleLiuKun
Copy link
Contributor Author

MerleLiuKun commented Nov 14, 2021 •
edited

I have rebase with newest to solve the pylint conflicts :) @k-ye @sjwsl

@sjwsl
Copy link
Collaborator

sjwsl commented Nov 14, 2021

Great! Now you need to fix some errors introduced by #3494 :)

sjwsl
sjwsl approved these changes Nov 14, 2021
View reviewed changes
Copy link
Collaborator

@sjwsl sjwsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sjwsl sjwsl merged commit 6aed454 into taichi-dev:master Nov 14, 2021
@MerleLiuKun MerleLiuKun deleted the pylint_W0612 branch November 14, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjwsl sjwsl sjwsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MerleLiuKun @CLAassistant @k-ye @sjwsl