Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lang] Fix pylint rule E1101 #3500

Merged
merged 6 commits into from Nov 16, 2021
Merged

[Lang] Fix pylint rule E1101 #3500

merged 6 commits into from Nov 16, 2021

Conversation

DeepDuke
Copy link
Contributor

Signed-off-by: DeepDuke czm.hit@gmail.com
Related issue = #3151

@CLAassistant
Copy link

CLAassistant commented Nov 14, 2021

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Nov 14, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: 41708bb

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/619375d942becf0008ce8355

@sjwsl
Copy link
Collaborator

sjwsl commented Nov 15, 2021

  1. Please use disable since disable-msg is deprecated as of pylint 0.21.0.
  2. Enabling this check but skipping it everywhere does nothing but increase the number of lines of code... Do you have a better way to resolve them? Otherwise, I think probably this check should not be enabled at all. WDYT?

@DeepDuke
Copy link
Contributor Author

  1. Please use disable since disable-msg is deprecated as of pylint 0.21.0.
  2. Enabling this check but skipping it everywhere does nothing but increase the number of lines of code... Do you have a better way to resolve them? Otherwise, I think probably this check should not be enabled at all. WDYT?

It seems pylint cannot parse pytorch ,opencv and some other special cases. But pylint does not fail in all situations. If don’t enable it, we will miss some checks ? I tried some other methods, but not work...

Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions:

  1. Mark E1101 as True in scripts/generate_pylint_tags.py
  2. Use disable instead of disable-msg

@DeepDuke
Copy link
Contributor Author

A few suggestions:

  1. Mark E1101 as True in scripts/generate_pylint_tags.py
  2. Use disable instead of disable-msg

I will fix it soon.

@DeepDuke
Copy link
Contributor Author

/format

1 similar comment
@strongoier
Copy link
Contributor

/format

Copy link
Collaborator

@sjwsl sjwsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@sjwsl sjwsl merged commit 343f260 into taichi-dev:master Nov 16, 2021
@DeepDuke
Copy link
Contributor Author

LGTM, thank you!
@sjwsl @strongoier
Thanks for your kind suggestions and guidance. It's my honor to participate in taichi project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants