Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Fix pylint conflicts #3503

Merged
merged 3 commits into from Nov 14, 2021
Merged

[ci] Fix pylint conflicts #3503

merged 3 commits into from Nov 14, 2021

Conversation

k-ye
Copy link
Member

@k-ye k-ye commented Nov 14, 2021

Related issue = #3151

@netlify
Copy link

netlify bot commented Nov 14, 2021 •
edited

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: b07d983

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/6190c6418d7a2c00087b441f

@k-ye k-ye requested review from ailzhang and sjwsl November 14, 2021 08:10
k-ye and others added 2 commits November 14, 2021 16:17
@k-ye
simplify
33914b0
@k-ye @sjwsl
Update scripts/generate_pylint_tags.py
b07d983 
Co-authored-by: Tianshu Xu <xts.sjwsl@gmail.com>
@k-ye k-ye changed the title [ci] Fix pylint conflits [ci] Fix pylint conflicts Nov 14, 2021
@sjwsl sjwsl self-requested a review November 14, 2021 08:19
sjwsl
sjwsl approved these changes Nov 14, 2021
View reviewed changes
Copy link
Collaborator

@sjwsl sjwsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could we temporarily skip CI for this one?

@k-ye
Copy link
Member Author

k-ye commented Nov 14, 2021

LGTM! Could we temporarily skip CI for this one?

Sure 😂 Could you send out the new rules for how to update the Pylint works, thx!

@k-ye k-ye merged commit 18b9472 into taichi-dev:master Nov 14, 2021
@k-ye k-ye deleted the pylint-tags branch November 14, 2021 08:28
@sjwsl sjwsl mentioned this pull request Nov 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjwsl sjwsl sjwsl approved these changes

@ailzhang ailzhang Awaiting requested review from ailzhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@k-ye @sjwsl