Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vulkan] Fix a few errors encountered when building for x86 #3523

Merged
merged 1 commit into from Nov 16, 2021
Merged

[vulkan] Fix a few errors encountered when building for x86 #3523

merged 1 commit into from Nov 16, 2021

Conversation

AmesingFlank
Copy link
Collaborator

Lessons learned:

  • Always prefer VK_NULL_HANDLE to nullptr
  • Always prefer VkDeviceSize to size_t

@netlify
Copy link

netlify bot commented Nov 15, 2021 •
edited

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: 3fe183d

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/6192c69489fb4b000773711b

k-ye
k-ye approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@k-ye k-ye merged commit 25ae1e6 into taichi-dev:master Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-ye k-ye k-ye approved these changes

@bobcao3 bobcao3 Awaiting requested review from bobcao3

@ailzhang ailzhang Awaiting requested review from ailzhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AmesingFlank @k-ye