Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [llvm] Fix FP<->UInt castings #3560

Merged
merged 3 commits into from Nov 21, 2021
Merged

Conversation

strongoier
Copy link
Contributor

Related issue = #3515

Castings between floating point numbers and unsigned integers are not handled correctly in LLVM backends. This PR aims at fixing it.

@netlify
Copy link

netlify bot commented Nov 19, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: e79133e

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/619a04461f0c9e00085ebe7e

@strongoier
Copy link
Contributor Author

/format

Copy link
Collaborator

@sjwsl sjwsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@strongoier strongoier merged commit 0888810 into taichi-dev:master Nov 21, 2021
@strongoier strongoier deleted the fix-3515 branch November 23, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants