Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix example link in README. #3584

Merged
merged 2 commits into from Nov 22, 2021
Merged

Conversation

egolearner
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Nov 22, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc ready!

🔨 Explore the source changes: 1f0e663

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/619b77a37d61cc0008fc0486

😎 Browse the preview: https://deploy-preview-3584--jovial-fermat-aa59dc.netlify.app

@CLAassistant
Copy link

CLAassistant commented Nov 22, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the quick fix!
Btw would you mind also help fixing the links in docs folder?

@ailzhang ailzhang changed the title [Doc]Fix example link in README. [Doc] Fix example link in README. Nov 22, 2021
@ailzhang
Copy link
Contributor

Hey @egolearner, would you mind signing the CLA above so that we can merge this? :D Thanks!

@ailzhang
Copy link
Contributor

FYI other links have been fixed in #3587 so this PR is ready to merge once CLA is signed :D

@yolo2themoon
Copy link
Collaborator

yolo2themoon commented Nov 22, 2021

By the way, could you please fix these lines in README.md? ;)

https://github.com/taichi-dev/taichi/blob/master/README.md?plain=1#L27
https://github.com/taichi-dev/taichi/blob/master/README.md?plain=1#L29
https://github.com/taichi-dev/taichi/blob/master/README.md?plain=1#L30

@egolearner
Copy link
Contributor Author

@egolearner
Copy link
Contributor Author

CLA assigned. :-)

@ailzhang ailzhang merged commit a714966 into taichi-dev:master Nov 22, 2021
@egolearner
Copy link
Contributor Author

@ailzhang thanks

@egolearner egolearner deleted the patch-1 branch November 22, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants