[refactor] Remove import taichi in ast_transformer #3827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for jovial-fermat-aa59dc canceled. 🔨 Explore the source changes: 7dec754 🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61c53fd467c76200087c11fa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #3782
In
taichi/lang/__init.py,from taichi.lang.ndrange import ndrangeis a bit confusing both to me and the IDE because it imports the classndrangeand shadows the modulendrange. But at the time of loadingast_transformer.py, this line is not yet executed. So, when Ifrom taichi.lang import ndrangeinast_transformer.py, it imports the module. In order to solve this confusing situation, I moved the import ofndrangetotaichi/__init__.py