Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Test] [aot] Add initial AOT CPP test" #3890

Merged
merged 1 commit into from
Dec 28, 2021
Merged

Conversation

k-ye
Copy link
Member

@k-ye k-ye commented Dec 27, 2021

Oops, just noticed that the test didn't build... Reverts #3850

@netlify
Copy link

netlify bot commented Dec 27, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: ffa3983

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61c9ce6e5e60a10008ae5727

@yuanming-hu
Copy link
Member

yuanming-hu commented Dec 27, 2021

Maybe an easier solution is guarding tests/cpp/aot/aot_save_load_test.cpp with #ifdef TI_WITH_VULKAN? :-)

It fails on CPU build bots, when the system is built with Vulkan tests while Taichi has no Vulkan backend support.
https://github.com/taichi-dev/taichi/runs/4602606608?check_suite_focus=true#step:7:455

@yuanming-hu
Copy link
Member

yuanming-hu commented Dec 27, 2021

It looks that GitHub CI fails in many ways today... Given there is no easy way for us to verify whether macro guarding works here, I agree that we should try to revert for now. (Sorry about my erroneous indication on #3850.)

@qiao-bo qiao-bo changed the title Revert "[Test][aot] Add initial AOT CPP test" Revert "[Test] [aot] Add initial AOT CPP test" Dec 28, 2021
Copy link
Collaborator

@qiao-bo qiao-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@k-ye k-ye merged commit 1b3e13e into master Dec 28, 2021
@k-ye k-ye deleted the revert-3850-aot_tests branch December 28, 2021 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants