[Refactor] Deprecate excepthook and completely remove _taichi_skip_traceback #3902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
✔️ Deploy Preview for jovial-fermat-aa59dc ready! 🔨 Explore the source changes: db2e487 🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61cbd57588f38a00074e096a 😎 Browse the preview: https://deploy-preview-3902--jovial-fermat-aa59dc.netlify.app |
|
/format |
strongoier
approved these changes
Dec 29, 2021
There was a problem hiding this comment.
LGTM! Regarding the traceback messages, it is OK to give suggestions like this for now. Just want to mention that @lin-hitonami is working on more user-friendly messages (one step is #3873).
This was referenced Dec 29, 2021
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
Jan 5, 2022
…aceback (taichi-dev#3902) * Deprecate excepthook and cleanup all _taichi_skip_traceback. * Auto Format Co-authored-by: Taichi Gardener <taichigardener@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #3775 #2489
Problem: with the introduction of pretty exception mechanism, the "excepthook" and "_taichi_skip_traceback" are no longer needed. Therefore I removed all occurrences and make respective changes to documents.
Briefing of changes: