Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lang] Initial matrix argument support for ti.kernel #3905

Merged
merged 8 commits into from
Dec 31, 2021

Conversation

mzmzm
Copy link
Contributor

@mzmzm mzmzm commented Dec 29, 2021

Related issue = #3904

@CLAassistant
Copy link

CLAassistant commented Dec 29, 2021

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Dec 29, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc ready!

🔨 Explore the source changes: 1f5b321

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61cd6b28f926ab00074ba43c

😎 Browse the preview: https://deploy-preview-3905--jovial-fermat-aa59dc.netlify.app

@strongoier
Copy link
Contributor

strongoier commented Dec 29, 2021

Welcome to the Taichi community! I suggest reading our contribution guide. The current step is to solve code format & style issues :-) See the unsuccessful checks below for more details.

@strongoier strongoier changed the title [Lang] Matrix argument supprot for ti.kernel [Lang] Initial matrix argument support for ti.kernel Dec 29, 2021
@mzmzm
Copy link
Contributor Author

mzmzm commented Dec 29, 2021

Thanks! I have fixed my code format error.

Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Only some nits.

tests/python/test_matrix_arg.py Outdated Show resolved Hide resolved
tests/python/test_matrix_arg.py Outdated Show resolved Hide resolved
tests/python/test_matrix_arg.py Outdated Show resolved Hide resolved
python/taichi/lang/kernel_arguments.py Outdated Show resolved Hide resolved
@mzmzm
Copy link
Contributor Author

mzmzm commented Dec 30, 2021

/format

Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@strongoier strongoier merged commit 6112014 into taichi-dev:master Dec 31, 2021
@mzmzm mzmzm deleted the dev branch January 12, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants