Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perf] Clear global_vars/matrix_fields after materialize() #3914

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

strongoier
Copy link
Contributor

Related issue = #3906

https://github.com/taichi-dev/taichi/runs/4664728269?check_suite_focus=true shows that #3906 causes performance regression. This PR aims at fixing it by clearing global_vars/matrix_fields after materialize() because they should not be handled in the next materialize().

@netlify
Copy link

netlify bot commented Dec 30, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: 56debf5

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61cd746a6cf96100074fbfb6

@yolo2themoon
Copy link
Collaborator

/benchmark

@taichi-gardener
Copy link
Contributor

current commit hash: 56debf5

master commit hash: 0abce04

Examples CUDA
benchmarks fluctuation threshold 5.0%
kernel improvement vortex_rings(-27.5858%), mpm128(-26.4935%), comet(-24.8713%), pbf2d(-22.0244%), mpm99(-18.7543%), fem128(-14.9942%), ad_gravity(-13.6921%), mpm88(-12.7889%), odop_solar(-11.7633%), mpm_lagrangian_forces(-11.4748%), fem99(-9.1789%),
kernel regression inital_value_problem(+7.3329%),
end2end improvement fem128(-94.2243%), mpm_lagrangian_forces(-93.9893%), fem99(-93.4416%), odop_solar(-88.1788%), pbf2d(-87.6037%), vortex_rings(-87.3154%), mpm128(-86.5948%), comet(-85.8337%), ad_gravity(-84.8365%), mpm99(-83.8713%), mpm88(-83.2098%), mpm3d(-11.4981%), game_of_life(-7.7122%), inital_value_problem(-6.1978%),
end2end regression None

@yolo2themoon yolo2themoon self-requested a review December 30, 2021 10:02
Copy link
Collaborator

@yolo2themoon yolo2themoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@yolo2themoon yolo2themoon merged commit 1f9b5c1 into taichi-dev:master Dec 30, 2021
@strongoier strongoier deleted the fix-3906-perf branch December 30, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants