Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[misc] Add a minimal example for micro-benchmarks #4031

Merged
merged 9 commits into from
Jan 20, 2022
Merged

[misc] Add a minimal example for micro-benchmarks #4031

merged 9 commits into from
Jan 20, 2022

Conversation

yolo2themoon
Copy link
Collaborator

@yolo2themoon yolo2themoon commented Jan 14, 2022 •
edited
Loading

Related issue = #4058

@vercel
Copy link

vercel bot commented Jan 14, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/A2G5zR9w5ibdtqAaHkMkGZzkZoC6
✅ Preview: Canceled

[Deployment for d1d297c canceled]

@netlify
Copy link

netlify bot commented Jan 14, 2022 •
edited
Loading

✔️ Deploy Preview for docsite-preview ready!

🔨 Explore the source changes: d1d297c

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61e9106fd311b70008a4a233

😎 Browse the preview: https://deploy-preview-4031--docsite-preview.netlify.app

lin-hitonami
lin-hitonami reviewed Jan 18, 2022
View reviewed changes
benchmarks/microbenchmarks/_result.py Outdated Show resolved Hide resolved
benchmarks/microbenchmarks/_utils.py Outdated Show resolved Hide resolved
benchmarks/microbenchmarks/_items.py Outdated Show resolved Hide resolved
benchmarks/microbenchmarks/_plan.py Outdated Show resolved Hide resolved
@yolo2themoon @lin-hitonami
apply suggestions
b943a2c 
Co-authored-by: Lin Jiang <90667349+lin-hitonami@users.noreply.github.com>
@yolo2themoon yolo2themoon mentioned this pull request Jan 19, 2022
Open
13 tasks
ailzhang
ailzhang reviewed Jan 19, 2022
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I have a basic idea how this works, but will leave the final review to @lin-hitonami :D

@yolo2themoon @lin-hitonami
Update benchmarks/microbenchmarks/_utils.py
d1d297c 
Co-authored-by: Lin Jiang <90667349+lin-hitonami@users.noreply.github.com>
lin-hitonami
lin-hitonami approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@lin-hitonami lin-hitonami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yolo2themoon yolo2themoon merged commit cfbf032 into taichi-dev:master Jan 20, 2022
@yolo2themoon yolo2themoon deleted the microbenchmark_minimal branch January 20, 2022 09:34
@yolo2themoon yolo2themoon mentioned this pull request Jan 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ailzhang ailzhang ailzhang left review comments

@lin-hitonami lin-hitonami lin-hitonami approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yolo2themoon @ailzhang @lin-hitonami