Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Improve Fields documentation #4063

Merged
merged 14 commits into from
Jan 27, 2022
Merged

[doc] Improve Fields documentation #4063

merged 14 commits into from
Jan 27, 2022

Conversation

yolo2themoon
Copy link
Collaborator

@yolo2themoon yolo2themoon commented Jan 19, 2022 •
edited
Loading

  • scalar fields
  • vector and matrix fields
  • struct fields

@vercel
Copy link

vercel bot commented Jan 19, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/BhZq5xLxb6HEK6f8A57LtSGAKKAo
✅ Preview: Canceled

[Deployment for 02a9f7d canceled]

@netlify
Copy link

netlify bot commented Jan 19, 2022 •
edited
Loading

✔️ Deploy Preview for docsite-preview ready!

🔨 Explore the source changes: 02a9f7d

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61f2685717a8bb000823d16d

😎 Browse the preview: https://deploy-preview-4063--docsite-preview.netlify.app

erizmr
erizmr reviewed Jan 20, 2022
View reviewed changes
docs/lang/articles/basic/field.md Outdated Show resolved Hide resolved
docs/lang/articles/basic/field.md Outdated Show resolved Hide resolved
docs/lang/articles/basic/field.md Outdated Show resolved Hide resolved
writinwaters
writinwaters suggested changes Jan 20, 2022
View reviewed changes
docs/lang/articles/basic/field.md Outdated Show resolved Hide resolved
docs/lang/articles/basic/field.md Outdated Show resolved Hide resolved
docs/lang/articles/basic/field.md Outdated Show resolved Hide resolved
@yolo2themoon
Copy link
Collaborator Author

/format

@writinwaters
Copy link
Contributor

LGTM!

@erizmr erizmr self-requested a review January 22, 2022 04:44
erizmr
erizmr approved these changes Jan 22, 2022
View reviewed changes
Copy link
Contributor

@erizmr erizmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yolo2themoon @FantasyVR
Update docs/lang/articles/basic/field.md
b2d434e 
Co-authored-by: Peng Yu <6712304+FantasyVR@users.noreply.github.com>
FantasyVR
FantasyVR reviewed Jan 24, 2022
View reviewed changes
Copy link
Collaborator

@FantasyVR FantasyVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

docs/lang/articles/basic/field.md Outdated Show resolved Hide resolved
docs/lang/articles/basic/field.md Outdated Show resolved Hide resolved
docs/lang/articles/basic/field.md Outdated Show resolved Hide resolved
FantasyVR
FantasyVR reviewed Jan 27, 2022
View reviewed changes
Copy link
Collaborator

@FantasyVR FantasyVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😄

docs/lang/articles/basic/field.md Outdated Show resolved Hide resolved
docs/lang/articles/basic/field.md Outdated Show resolved Hide resolved
@yolo2themoon @FantasyVR
Update docs/lang/articles/basic/field.md
33f8f3b 
Co-authored-by: Peng Yu <6712304+FantasyVR@users.noreply.github.com>
taichiCourse01
taichiCourse01 approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@taichiCourse01 taichiCourse01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FantasyVR
FantasyVR approved these changes Jan 27, 2022
View reviewed changes
Copy link
Collaborator

@FantasyVR FantasyVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ailzhang
ailzhang approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yolo2themoon yolo2themoon merged commit 0f27bb5 into taichi-dev:master Jan 27, 2022
@yolo2themoon yolo2themoon deleted the doc_field branch January 27, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ailzhang ailzhang ailzhang approved these changes

@FantasyVR FantasyVR FantasyVR approved these changes

@erizmr erizmr erizmr approved these changes

@taichiCourse01 taichiCourse01 taichiCourse01 approved these changes

@writinwaters writinwaters writinwaters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@yolo2themoon @writinwaters @ailzhang @FantasyVR @erizmr @taichiCourse01 @taichi-gardener