Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Improve operators page #4073

Merged
merged 9 commits into from
Feb 15, 2022
Merged

[doc] Improve operators page #4073

merged 9 commits into from
Feb 15, 2022

Conversation

lin-hitonami
Copy link
Contributor

Related issue = #

@vercel
Copy link

vercel bot commented Jan 20, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/ASMmt3upw8Xo4cMRYBit2fQQuBW6
✅ Preview: Canceled

[Deployment for e7fb926 canceled]

@netlify
Copy link

netlify bot commented Jan 20, 2022 •
edited
Loading

✔️ Deploy Preview for docsite-preview ready!

🔨 Explore the source changes: e7fb926

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61f2333fd9d9970007deef2d

😎 Browse the preview: https://deploy-preview-4073--docsite-preview.netlify.app

qiao-bo
qiao-bo approved these changes Jan 20, 2022
View reviewed changes
Copy link
Collaborator

@qiao-bo qiao-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

strongoier
strongoier approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

writinwaters
writinwaters suggested changes Jan 26, 2022
View reviewed changes
docs/lang/articles/basic/operator.md Outdated Show resolved Hide resolved
docs/lang/articles/basic/operator.md Outdated Show resolved Hide resolved
@lin-hitonami @writinwaters
Update docs/lang/articles/basic/operator.md
0e42f97 
Co-authored-by: Vissidarte-Herman <93570324+Vissidarte-Herman@users.noreply.github.com>
@lin-hitonami
Copy link
Contributor Author

Don't merge before the next version releases.

qiao-bo
qiao-bo approved these changes Jan 26, 2022
View reviewed changes
Copy link
Collaborator

@qiao-bo qiao-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny nit: it's better to split the CPU/CUDA into two columns in the table, as we did in the type system page ;/ Other than that, looks great, thanks!

@writinwaters writinwaters self-requested a review January 26, 2022 10:58
@bobcao3 bobcao3 merged commit a14ed16 into taichi-dev:master Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiao-bo qiao-bo qiao-bo approved these changes

@mzmzm mzmzm Awaiting requested review from mzmzm

@strongoier strongoier Awaiting requested review from strongoier

@writinwaters writinwaters Awaiting requested review from writinwaters

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lin-hitonami @strongoier @qiao-bo @writinwaters @bobcao3