Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Remove dependency on get_current_program() in ui/backends/vulkan #4076

Merged
merged 10 commits into from
Jan 22, 2022
Merged

[refactor] Remove dependency on get_current_program() in ui/backends/vulkan #4076

merged 10 commits into from
Jan 22, 2022

Conversation

PGZXB
Copy link
Contributor

@PGZXB PGZXB commented Jan 20, 2022

Related issue = #3955

@vercel
Copy link

vercel bot commented Jan 20, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/F5vEkFW28T3dbNmQ3b65pJRtfPUK
✅ Preview: https://taichi-git-fork-pgzxb-dev-rm-gcp-385dc3-taichi-api-docs-preview.vercel.app

@netlify
Copy link

netlify bot commented Jan 20, 2022 •
edited
Loading

✔️ Deploy Preview for docsite-preview ready!

🔨 Explore the source changes: 28faf5a

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61ec096cab6f3600082c3773

😎 Browse the preview: https://deploy-preview-4076--docsite-preview.netlify.app

@PGZXB PGZXB changed the title [refactor] Remove dependency on get_current_program() in ui/backends/vulkan/renderables [refactor] Remove dependency on get_current_program() in ui/backends/vulkan Jan 21, 2022
k-ye
k-ye approved these changes Jan 22, 2022
View reviewed changes
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + nit!

python/taichi/ui/window.py Outdated Show resolved Hide resolved
@AmesingFlank
Copy link
Collaborator

AmesingFlank commented Jan 22, 2022 •
edited
Loading

Let's make the Program* a member of AppContext, which can be accessed by all the renderer/renderable classes. This way you won't have to pass around the Program*.

AmesingFlank
AmesingFlank approved these changes Jan 22, 2022
View reviewed changes
Copy link
Collaborator

@AmesingFlank AmesingFlank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thanks!

taichi/ui/backends/vulkan/canvas.h Outdated Show resolved Hide resolved
@strongoier strongoier merged commit 3b9ac51 into taichi-dev:master Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmesingFlank AmesingFlank AmesingFlank approved these changes

@k-ye k-ye k-ye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PGZXB @AmesingFlank @k-ye @strongoier