Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Fix warnings on external functions on windows #4079

Merged
merged 3 commits into from
Jan 21, 2022

Conversation

lin-hitonami
Copy link
Contributor

@lin-hitonami lin-hitonami commented Jan 20, 2022

Related issue = close #4074

@vercel
Copy link

vercel bot commented Jan 20, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/4vtWcB7ewinDiZXeXxMqFxES2RLV
✅ Preview: https://taichi-git-fork-lin-hitonami-fix-a57b20-taichi-api-docs-preview.vercel.app

@netlify
Copy link

netlify bot commented Jan 20, 2022

✔️ Deploy Preview for docsite-preview ready!

🔨 Explore the source changes: 0d581a7

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61e92b8d930d400007b61969

😎 Browse the preview: https://deploy-preview-4079--docsite-preview.netlify.app

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it!

@lin-hitonami lin-hitonami merged commit e8128fd into taichi-dev:master Jan 21, 2022
@lin-hitonami lin-hitonami deleted the fix_windows_warning branch January 21, 2022 00:53
ailzhang pushed a commit that referenced this pull request Jan 25, 2022
* [bug] Fix warnings on external functions on windows

* fix pylint

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Many taichi APIs are non-taichi functions
2 participants