[refactor] [ir] Refactor ExternalFuncCallExpression into a frontend stmt #4098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/5RRniSYjBkeVB2mbnNTBc2cPbySu [Deployment for 88354ba canceled] |
re-xyr
force-pushed
the
external_func_call_stmt
branch
from
1d917ea
to
88354ba
Compare
|
✔️ Deploy Preview for docsite-preview canceled. 🔨 Explore the source changes: 1d917ea 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61ee2525efd04f0007ed51eb |
|
✔️ Deploy Preview for docsite-preview canceled. 🔨 Explore the source changes: 88354ba 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61ee259d86784e000813373d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #4035
ExternalFuncCallExpressions do not have return values and are always wrapped inFrontendExprStmts. Therefore it'll be better if it is just a stmt by itself.