Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Remove dependency on get_current_program() and lang::current_ast_builder() in lang::Expr #4103

Merged
merged 4 commits into from
Jan 27, 2022
Merged

[refactor] Remove dependency on get_current_program() and lang::current_ast_builder() in lang::Expr #4103

merged 4 commits into from
Jan 27, 2022

Conversation

PGZXB
Copy link
Contributor

@PGZXB PGZXB commented Jan 24, 2022

Related issue = #3955

Most of changes are in svd.h, which I think are unavoidable.

@vercel
Copy link

vercel bot commented Jan 24, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/Ht2VG8tM9LMeHAUdMfxYZFB2GiWd
✅ Preview: https://taichi-git-fork-pgzxb-dev-rm-gcp-88f96c-taichi-api-docs-preview.vercel.app

[Deployment for 08a8eee canceled]

@netlify
Copy link

netlify bot commented Jan 24, 2022 •
edited
Loading

✔️ Deploy Preview for docsite-preview canceled.

🔨 Explore the source changes: 08a8eee

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61f245dbf8eb3200086da673

@PGZXB PGZXB mentioned this pull request Jan 25, 2022
Closed
3 tasks
@PGZXB PGZXB requested a review from strongoier January 27, 2022 03:55
@strongoier
Copy link
Contributor

Could you resolve the conflicts again? We have a large amount of PRs recently. Sorry about that.

@PGZXB
Copy link
Contributor Author

PGZXB commented Jan 27, 2022

Could you resolve the conflicts again? We have a large amount of PRs recently. Sorry about that.

FINISHED

strongoier
strongoier approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@strongoier strongoier merged commit 5b4f4bd into taichi-dev:master Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strongoier strongoier strongoier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PGZXB @strongoier