Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Do not expose internal function in ti.lang.impl #4134

Merged
merged 14 commits into from
Jan 27, 2022
Merged

[Refactor] Do not expose internal function in ti.lang.impl #4134

merged 14 commits into from
Jan 27, 2022

Conversation

mzmzm
Copy link
Contributor

@mzmzm mzmzm commented Jan 26, 2022

Related issue = #3782

@vercel
Copy link

vercel bot commented Jan 26, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/6ryAmK6Tmr4QbMtx7EKJXEodJP39
✅ Preview: https://taichi-git-fork-mzmzm-donotexpose-taichi-api-docs-preview.vercel.app

@netlify
Copy link

netlify bot commented Jan 26, 2022 •
edited
Loading

✔️ Deploy Preview for docsite-preview ready!

🔨 Explore the source changes: 3bfafa1

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61f0fae7276fca000869a500

😎 Browse the preview: https://deploy-preview-4134--docsite-preview.netlify.app

@mzmzm
Copy link
Contributor Author

mzmzm commented Jan 26, 2022

/format

@mzmzm
fix
0783b18
@mzmzm
Merge remote-tracking branch 'origin/do_not_expose' into do_not_expose
622a2b1 
# Conflicts:
#	tests/python/test_ast_refactor.py
#	tests/python/test_matrix.py
@mzmzm
fix
29d131d
@mzmzm
Copy link
Contributor Author

mzmzm commented Jan 26, 2022

/format

lin-hitonami
lin-hitonami approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@lin-hitonami lin-hitonami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mzmzm mzmzm merged commit 4cb9b71 into taichi-dev:master Jan 27, 2022
@mzmzm mzmzm deleted the do_not_expose branch January 27, 2022 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lin-hitonami lin-hitonami lin-hitonami approved these changes

@strongoier strongoier Awaiting requested review from strongoier

@k-ye k-ye Awaiting requested review from k-ye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mzmzm @lin-hitonami @taichi-gardener