Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Do not expose TapeImpl to users #4148

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

strongoier
Copy link
Contributor

Related issue = #3782

@vercel
Copy link

vercel bot commented Jan 26, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/6QASb7yFmHUeUg8Fpj4BQyzemYpo
✅ Preview: https://taichi-git-fork-strongoier-no-ex-301cba-taichi-api-docs-preview.vercel.app

@netlify
Copy link

netlify bot commented Jan 26, 2022

✔️ Deploy Preview for docsite-preview ready!

🔨 Explore the source changes: 2356fdc

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61f1129a8f4693000719e922

😎 Browse the preview: https://deploy-preview-4148--docsite-preview.netlify.app

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ailzhang ailzhang merged commit f2892e6 into taichi-dev:master Jan 27, 2022
@strongoier strongoier deleted the no-expose-tapeimpl branch January 27, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants