Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Major revision to the field (advanced) document #4156

Merged
merged 15 commits into from
Feb 9, 2022
Merged

[doc] Major revision to the field (advanced) document #4156

merged 15 commits into from
Feb 9, 2022

Conversation

turbo0628
Copy link
Member

@turbo0628 turbo0628 commented Jan 26, 2022

This PR conducts major revision to the advanced field document.

I removed some complex code examples and tried to refactor the description sentences. I think this document looks clearer, but not good enough yet. Let's review the new version and improve the contents together :)

@vercel
Copy link

vercel bot commented Jan 26, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/8urzrZGfpiB2P2ksB8USUsRJbah3
✅ Preview: Canceled

[Deployment for 5c563f2 canceled]

@netlify
Copy link

netlify bot commented Jan 26, 2022

✔️ Deploy Preview for docsite-preview ready!

🔨 Explore the source changes: 3f46dc1

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/6203688041bed500082fff15

😎 Browse the preview: https://deploy-preview-4156--docsite-preview.netlify.app

@turbo0628 turbo0628 changed the title [Doc] Major revision to the field (advanced) document [doc] Major revision to the field (advanced) document Jan 26, 2022
Co-authored-by: Bo Qiao <boqiao@taichi.graphics>
Copy link
Collaborator

@qiao-bo qiao-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the efforts! Just some suggestions from my side.

Co-authored-by: Bo Qiao <boqiao@taichi.graphics>
Co-authored-by: rocket <87978259+yolo2themoon@users.noreply.github.com>
Copy link
Collaborator

@qiao-bo qiao-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my second round of picky-picky ;// the rest looks good to me~

turbo0628 and others added 3 commits January 30, 2022 17:05
Copy link
Collaborator

@qiao-bo qiao-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@turbo0628
Copy link
Member Author

Thanks a lot for Bo's excellent review!

@turbo0628
Copy link
Member Author

/format

@turbo0628
Copy link
Member Author

/format

@turbo0628 turbo0628 merged commit c0c4f82 into taichi-dev:master Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants