-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Major revision to the field (advanced) document #4156
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/8urzrZGfpiB2P2ksB8USUsRJbah3 [Deployment for 5c563f2 canceled] |
✔️ Deploy Preview for docsite-preview ready! 🔨 Explore the source changes: 3f46dc1 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/6203688041bed500082fff15 😎 Browse the preview: https://deploy-preview-4156--docsite-preview.netlify.app |
Co-authored-by: Bo Qiao <boqiao@taichi.graphics>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the efforts! Just some suggestions from my side.
Co-authored-by: Bo Qiao <boqiao@taichi.graphics>
Co-authored-by: rocket <87978259+yolo2themoon@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my second round of picky-picky ;// the rest looks good to me~
Co-authored-by: Bo Qiao <boqiao@taichi.graphics>
Co-authored-by: Bo Qiao <boqiao@taichi.graphics>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks a lot for Bo's excellent review! |
/format |
/format |
This PR conducts major revision to the advanced field document.
I removed some complex code examples and tried to refactor the description sentences. I think this document looks clearer, but not good enough yet. Let's review the new version and improve the contents together :)