[bug] [opengl] Process child nodes to compute alignment #4191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to process `snode.ch` in the order of their `mem_offset_in_parent` so that the computed alignment is correct. Also noticed the minimization autodiff test had a too strict rel so relaxing it a bit.
|
✔️ Deploy Preview for docsite-preview canceled. 🔨 Explore the source changes: 20aaa9b 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61f4a56b25c17300072d1d24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to process
snode.chin the order of theirmem_offset_in_parentso that the computed alignment is correct.Also noticed the minimization autodiff test had a too strict
rel(fails randomly on master) sorelaxing it a bit.
Related issue = #