Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Update demo code in readme doc #4193

Merged
merged 1 commit into from
Jan 29, 2022
Merged

Conversation

Tiny-Box
Copy link
Contributor

Related issue = #

[Taichi] version 0.8.11, llvm 10.0.0, commit 9d0973e, osx, python 3.9.5

When I tried to run taichi with the demo in the readme, I found that the demo code in the readme has not been updated for a long time, and this code does not work in the current version.
After prompting I found the code for fractal.py, which is updated in the readme.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


wangyanxiang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@netlify
Copy link

netlify bot commented Jan 29, 2022

✔️ Deploy Preview for docsite-preview canceled.

🔨 Explore the source changes: bf740ae

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61f4be7b793347000778f3ef

@Tiny-Box Tiny-Box changed the title [Doc] update demo code in readme doc [doc] Update demo code in readme doc Jan 29, 2022
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, thanks for catching this. LGTM!

@k-ye k-ye merged commit f4d11e6 into taichi-dev:master Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants