[vulkan] Fix MoltenVK support #4205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for docsite-preview ready! 🔨 Explore the source changes: 845a505 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/62009307f8d4a40007be47f5 😎 Browse the preview: https://deploy-preview-4205--docsite-preview.netlify.app |
|
/format |
bobcao3
force-pushed
the
bobcao3/vulkan
branch
from
9ccf07f
to
46e29e6
Compare
|
/format |
1 similar comment
|
/format |
bobcao3
force-pushed
the
bobcao3/vulkan
branch
from
b4b9ae7
to
fab0b4f
Compare
|
/format |
1 similar comment
|
/format |
This reverts commit c8f0340.
bobcao3
force-pushed
the
bobcao3/vulkan
branch
from
8ae345d
to
1ef290f
Compare
lin-hitonami
reviewed
Feb 7, 2022
| @@ -209,13 +210,14 @@ jobs: | |||
|
|
|||
| - name: Build | |||
| run: | | |||
| brew install molten-vk | |||
There was a problem hiding this comment.
Should we brew uninstall molten-vk after we complete the building process to make sure the test can pass without molten-vk?
There was a problem hiding this comment.
Sure, if it does not take a lot of time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #3030
Depending PR = https://github.com/taichi-dev/taichi/pull/4202/files (merged)
This fixes the MoltenVK support on mac.
Fixes & improvements include:
dlopento load MoltenVK and use Volk (with custom loader) to handle the rest of loading. This avoids the@rpaththing on mac, and makes Molten actually shippableIn addition to be able to run and ship MoltenVK, this also gurantees the SPIR-V codegen will work when translated to MSL (as that is what MoltenVK do under the hood). This helps our on-going AOT effort.
Vulkan testing is added for M1, and vulkan is added in release for all macOS variants