[gui] Add more camera controls #4212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for docsite-preview ready! 🔨 Explore the source changes: e04577b 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/62008dc0e3ac3b0007128baa 😎 Browse the preview: https://deploy-preview-4212--docsite-preview.netlify.app |
|
I don't think we should bind these keys for special purposes here, just let the users do that. (Also |
|
@neozhaoliang, thanks for your suggestion. This is not a default setting, this preset is enabled only when users use camera.track_user_inputs(window=..., movement_speed=..., hold_key=...)And in that situation, I think users wish they can control the camera in a simple and flexible way. So I think this change is a preferred way for users. |
|
/rerun |
bobcao3
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the convention of game engines, and also for the user experience, I add two camera controlling commands :
q: Move camera down vertically.e: Move camera up vertically.