[lang] Annotate constants with dtype without casting. #4224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for docsite-preview ready! 🔨 Explore the source changes: a6d5c09 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/6202408662b5340007217fb8 😎 Browse the preview: https://deploy-preview-4224--docsite-preview.netlify.app |
ailzhang
force-pushed
the
const_with_dt
branch
from
c92bea1
to
ef68cf3
Compare
lin-hitonami
reviewed
Feb 8, 2022
Fixes taichi-dev#4210 This PR also simplifies the clamping logic by: 1. Make sure constant is valid in range of specified dtype. 2. Always use int64/float64 to communicate between python and C++ and converts it to the specified dtype in C++. This is just to avoid handling each dtype on both python and C++ side. We might consider further improve it by moving this logic from python to C++ in the future and this PR made it a step closer.
ailzhang
force-pushed
the
const_with_dt
branch
from
ef68cf3
to
a6d5c09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4210
This PR also simplifies the clamping logic by:
converts it to the specified dtype in C++. This is just to avoid
handling each dtype on both python and C++ side.
We might consider further improve it by moving this logic from python to C++ in the future and this PR made it a step closer.
Related issue = #